A new survey reveals whether Americans prefer the stock market or real estate for long-term investments, and why younger investors remain hesitant about cryptocurrency.